Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.2.0 #16

Merged
merged 1 commit into from
Dec 1, 2024
Merged

release: v1.2.0 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/Release-pypi.yml → .github/workflows/Release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
name: Release-pypi
name: Release

on:
workflow_dispatch:

push:
tags:
- "v*"

jobs:
Pypi:
pypi:
strategy:
matrix:
python-version: ["3.9"]
Expand Down Expand Up @@ -32,3 +36,14 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.PYPI_API }}

github:
needs: [pypi]
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
with:
submodules: recursive

- name: Release
uses: softprops/action-gh-release@v2
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ license = "GPL-3.0-only"
name = "yuisub"
readme = "README.md"
repository = "https://github.com/TensoRaws/yuisub"
version = "1.1.2"
version = "1.2.0"

# Requirements
[tool.poetry.dependencies]
Expand Down
18 changes: 18 additions & 0 deletions tests/test_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,24 @@
from . import util


def test_translator_sub_init() -> None:
translator = SubtitleTranslator(
torch_device=util.DEVICE,
whisper_model=util.MODEL_NAME,
model=util.OPENAI_MODEL,
api_key=util.OPENAI_API_KEY,
base_url=util.OPENAI_BASE_URL,
bangumi_url=util.BANGUMI_URL,
bangumi_access_token=util.BANGUMI_ACCESS_TOKEN,
)
Comment on lines +10 to +19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): Test should verify error cases for invalid initialization parameters

The test only covers the happy path of initialization. Consider adding test cases for invalid parameters such as empty API keys, invalid URLs, or unsupported model names. This would help ensure the SubtitleTranslator handles initialization errors gracefully.

def test_translator_sub_init() -> None:
    with pytest.raises(ValueError):
        SubtitleTranslator(
            torch_device=util.DEVICE,
            whisper_model=util.MODEL_NAME,
            model=util.OPENAI_MODEL,
            api_key="",
            base_url="invalid_url",
            bangumi_url=util.BANGUMI_URL,
            bangumi_access_token=util.BANGUMI_ACCESS_TOKEN,
        )


assert translator.model == util.OPENAI_MODEL
assert translator.api_key == util.OPENAI_API_KEY
assert translator.base_url == util.OPENAI_BASE_URL
assert translator.bangumi_url == util.BANGUMI_URL
assert translator.bangumi_access_token == util.BANGUMI_ACCESS_TOKEN


@pytest.mark.skipif(os.environ.get("GITHUB_ACTIONS") == "true", reason="Skipping test when running on CI")
async def test_translator_sub() -> None:
translator = SubtitleTranslator(
Expand Down