Missing spells / custom spells #34
Comments
|
send PR with wherever you need to be changed
…------ Original Message ------
From "izy" ***@***.***>
To "Tercioo/Open-Raid-Library" ***@***.***>
Cc "Subscribed" ***@***.***>
Date 10-Jun-23 3:59:58 PM
Subject [Tercioo/Open-Raid-Library] Missing spells / custom spells
(Issue #34)
I am thinking to use this lib in my addon but I see that some spells
are missing like Grounding totem , Skyfury totem (i checked on my resto
shaman) , not sure if its only the pvp spells that are missing or just
some random spells.
Is is possible to add more spells without modifying
ThingsToMantain_Dragonflight.lua ? Or do you consider to update the
spells list?
I am not sure what the behavior will be if for example there are two or
more addons that are using the lib, i want to sync some spells when in
party/raid that are not in the list.
—
Reply to this email directly, view it on GitHub
<#34>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEVKWA3TH7VBUGHPBUXKSDXKS725ANCNFSM6AAAAAAZB22FBE>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
|
One solution can be to be able to merge spells from a custom table with the table in Open-Raid-Library on load so we can add the missing spells from the addon without touching the lib, this way at least who has my addon can get the spells sync for all spells. Second solution is to add all the spells in ORL list but thats more work for you, sending PR each time stuff changes is not great. Also you could enable sync for all the player spells. At the moment my sync implementation without ORL looks something like this Here is a list with all the spells from my addon , many of them are missing in Open-Raid-Library (and seems that there arent any pvp spells in your list). Cooldowns LIST |
|
Also after reload it seems that ORL doesnt check for "player" cooldowns and there is no way to sync if a player reloads UI / relogs until he reuses the spell. Edit: I checked and it does but spells on cooldown are not registered for sync , for example if a spell is reduced by other spell and you reload the UI while the spell is on cooldown and you are using the spell that reduces the cooldown i dont get any event , it works after the spell goes off cd and reusing it. Also after some testing im getting this error all the time (tested in BGs): At the first look it seems to be a problem only with the spells from --interrupts section when receiving info from other players (with Details for example) but it doesnt seem to happen with Details only with my implementation that looks something like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am thinking to use this lib in my addon but I see that some spells are missing like Grounding totem , Skyfury totem (i checked on my resto shaman) , not sure if its only the pvp spells that are missing or just some random spells.
Is is possible to add more spells without modifying ThingsToMantain_Dragonflight.lua ? Or do you consider to update the spells list?
I am not sure what the behavior will be if for example there are two or more addons that are using the lib, i want to sync some spells when in party/raid that are not in the list.
The text was updated successfully, but these errors were encountered: