Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooldown Pet support #5

Open
MichelPate opened this issue May 26, 2022 · 5 comments
Open

Cooldown Pet support #5

MichelPate opened this issue May 26, 2022 · 5 comments

Comments

@MichelPate
Copy link

I was wondering if there was any plan to support pets in the unit cooldowns ?
Can't track warlocks interrupts for instance at the moment.

@Tercioo
Copy link
Owner

Tercioo commented May 26, 2022 via email

@MichelPate
Copy link
Author

When I run this code on my warlock

for unitName, cooldowns in pairs (openRaidLib.GetAllUnitsCooldown()) do 
    print (unitName)
    for spellID in pairs (cooldowns) do
        print (spellID)
    end
end

It doesn't return my pets cooldown either as a separate unit nor inside of warlock coodowns.

Plumate
111898
108416
104773
89766
265187
30283
333889

I've tried

openRaidLib.GetUnitCooldowns("pet")

doesn't return anything either

@Tercioo
Copy link
Owner

Tercioo commented May 28, 2022

I need your help to help you, I don't play as warlock and I need baby steps on how these interrupt spells are available to you.
Let's take as example the spell '111898', the game reports it's a spell called "Grimoire: Felguard", I need to know:
Which specs of the warlock class can use it
Is this interrupt require a talent?
Which pet the warlock need to use to cast this interrupt?

Thank you!

@MichelPate
Copy link
Author

MichelPate commented May 28, 2022

Sure let me help you to help me so ; ) I'm not a warlock myself, but here are few things that I know. Each warlock pet has a unique Command Demon Ability.

  1. Felguard (npcID : 17252) : Axe Toss (spellID : 119914) Interrupt/Stun
  2. Imp (npcID : 416) : Singe Magic (spellID : 119905) Dispel
  3. Voidwalker (npcID : 1860) : Shadow Bulwark (spellID : 119907) +30% Health for 20sec
  4. Felhunter (npcID : 417) : Spell Lock (spellID : 119910) Interrupt
  5. Incubus (npcID : 184600) : Seduction (spellID : 119909) Disorient/Fear

Those abilities are shared by every spec of the warlock, they belong to the pets.
On the otherhand Grimoire: Felguard (spellID: 111898) is a Talent which summon a unit/pet that you CAN'T control so it's a cooldown like any other I guess.

I think the only thing missing right now is the ability to track pet cooldowns.

@MichelPate
Copy link
Author

MichelPate commented May 28, 2022

I'm deeply sorry, I've just figured out it is working as intended but I wasn't using the good spellID, apparently the spellID from warlock spellbook is different from the spellID used by the pet.
For instance Axe Toss is 119914 in Spellbook but 89766 in SPELLCAST ...

Anyway I think you should add in ThingsToMantain.lua all the pets's spells in every specs :

  1. Spell Lock 19647
    (2. Axe Toss 89766 ) Only in Demonology
  2. Singe Magic 89808
  3. Shadow Bulwark 119907
  4. Seduction 6358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants