Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The entire library compilation on MSVC breaks when including Windows.h #80

Open
japopich opened this issue Jan 2, 2025 · 0 comments
Open

Comments

@japopich
Copy link

japopich commented Jan 2, 2025

Hello,

So, I have recently run into a very interesting situation when trying to compile robin-map on windows with MSVC.
If I try to compile robin-map by itself I can compile successfully, but if I include robin-map via cmake FETCH on my current project I get over 140 errors that is directly tied to my project including Windows.h and I believe it might be related to the use of min and max in the library.

Here is a related link that might present a better picture of what I believe the issue is: https://belaycpp.com/2021/05/11/windows-h-breaks-the-stl-and-my-will-to-live/

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant