Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sector-size as cli argument #14

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

Teufelchen1
Copy link
Owner

This PR aims to fix #12
It is currently working however, I encountered some issue with XMUs. Additional digging and information research is necessary. At the moment, the PR contains an experimental change that adds a new termination magic for Directory entry lists.

@Teufelchen1
Copy link
Owner Author

Hm I think I'll merge now. The change is unlikely to affect much, its minor. Tested a lot with local images. Should be alright. I'll open an additional issue to revise that later again

@Teufelchen1 Teufelchen1 merged commit fa95330 into master Jun 12, 2020
@JayFoxRox
Copy link

I only saw this PR now; what does this mean?

It is currently working however, I encountered some issue with XMUs.

@Teufelchen1
Copy link
Owner Author

Teufelchen1 commented Jun 12, 2020

(Almost) Empty XMUs appear to use the non-standard 0x00 as termination for DirectoryEntry lists. I fixed it by adding 0x00 as also being a valid termination. However, its hard to test & research. I'm positiv adding it won't cause trouble for regular images(i.e. without corruption). I opened a new issue for that nonetheless. See #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add options for media geometry
2 participants