-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threads show anyone who has viewed the thread as participants #1371
Comments
It actually shows anyone who joined the thread by clicking on the join button. My guess is people joined the thread because they were not able to view files/images shared on the thread without joining |
That's plausible, no images in that particular thread though. How about auto-join on first reply instead of explicitly joining ? |
All channel members should have read access to the thread (need not be participants and need not be notified of the thread activity - other than seeing the number of replies and seeing all the thread messages upon opening the thread) |
Yeah makes sense. |
The problem is that we're showing channel members (threads are also channels) in the card - and someone who hasn't replied but has notifications turned on for the thread would also show up. We could fetch all the "participants" by grouping all messages by owner in the thread and show that. There's a performance penalty though since channel members are cached in the system - so it's faster as opposed to running a SQL query for participants. |
IMO it should be just those who've replied on the thread.
E.g:
The text was updated successfully, but these errors were encountered: