Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads show anyone who has viewed the thread as participants #1371

Open
ankush opened this issue Feb 20, 2025 · 6 comments
Open

Threads show anyone who has viewed the thread as participants #1371

ankush opened this issue Feb 20, 2025 · 6 comments

Comments

@ankush
Copy link

ankush commented Feb 20, 2025

IMO it should be just those who've replied on the thread.

E.g:

Image

Copy link

linear bot commented Feb 20, 2025

@ankush ankush changed the title Threads show anyone who has viewed the thread as particpants. Threads show anyone who has viewed the thread as participants Feb 20, 2025
@nikkothari22
Copy link
Member

It actually shows anyone who joined the thread by clicking on the join button. My guess is people joined the thread because they were not able to view files/images shared on the thread without joining

@ankush
Copy link
Author

ankush commented Feb 20, 2025

That's plausible, no images in that particular thread though.

How about auto-join on first reply instead of explicitly joining ?

@janhvipatil
Copy link
Member

All channel members should have read access to the thread (need not be participants and need not be notified of the thread activity - other than seeing the number of replies and seeing all the thread messages upon opening the thread)
They become active participants when they reply in the thread.
But what if the user wants to be notified of the thread messages without replying in the thread (i.e wants to be a participant)? They probably should have an option to join in the conversation?

@ankush
Copy link
Author

ankush commented Feb 20, 2025

Yeah makes sense.

@nikkothari22
Copy link
Member

nikkothari22 commented Feb 20, 2025

The problem is that we're showing channel members (threads are also channels) in the card - and someone who hasn't replied but has notifications turned on for the thread would also show up. We could fetch all the "participants" by grouping all messages by owner in the thread and show that. There's a performance penalty though since channel members are cached in the system - so it's faster as opposed to running a SQL query for participants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants