New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache number of replies in a thread #1401

Open

nikkothari22 opened this issue Feb 25, 2025 · 1 comment

Assignees

Labels

🏃🏻 performance

Member

nikkothari22 commented Feb 25, 2025

When a new thread reply is created, all clients that are on the page make a request to frappe.client.get_count :/

This can be avoided in a few ways:

In the realtime event for thread_reply_created - send whether a message was created, deleted, or updated. We could then decide whether to fetch the new count or not - no need to fetch for updates to existing messages
Use a new API to fetch number of thread replies which reads from the cache. Cache needs to be invalidated when a message in a thread is created or deleted.

nikkothari22 added the 🏃🏻 performance label

nikkothari22 self-assigned this

linear bot commented Feb 25, 2025

RAV-138 Cache number of replies in a thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment