Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs-data parquets include erroneous 'maternity' mitigators #51

Open
matt-dray opened this issue Feb 24, 2025 · 2 comments
Open

Inputs-data parquets include erroneous 'maternity' mitigators #51

matt-dray opened this issue Feb 24, 2025 · 2 comments
Labels
techdebt Make hastily-written code easier to maintain

Comments

@matt-dray
Copy link

matt-dray commented Feb 24, 2025

The parquets containing rates, age-sex, procedures and diagnoses data contain these erroneous strategies:

  • consultant_to_consultant_reduction_maternity
  • convert_to_tele_maternity
  • followup_reduction_maternity
  • gp_referred_first_attendance_reduction_maternity

These aren't recognised mitigators. Ideally we would prevent these from being generated (unless there's a good reason?).

@matt-dray matt-dray added the techdebt Make hastily-written code easier to maintain label Feb 24, 2025
@matt-dray matt-dray changed the title Rates data for the inputs app includes maternity mitigators Parquets for the inputs app include 'maternity' mitigators Feb 24, 2025
@matt-dray matt-dray changed the title Parquets for the inputs app include 'maternity' mitigators Inputs-data parquets include erroneous 'maternity' mitigators Feb 24, 2025
@tomjemmett
Copy link
Member

tomjemmett commented Feb 25, 2025

@yiwen-h I thought the intention on these was that we would not include them as mitigators? IIRC because the thought is this is activity that is likely to grow?

so the question is, do we care that these are being generated (but not used) in the inputs data?

the solution if we wanted to remove would be to insert a filter [https://github.com/The-Strategy-Unit/nhp_data/blob/add_demographics/inputs_data/op/init.py#L39](in the op file) to exclude type == "maternity"

@yiwen-h
Copy link
Member

yiwen-h commented Feb 25, 2025

I think we implement this, it's confusing to make things that aren't used

the solution if we wanted to remove would be to insert a filter[https://github.com/The-Strategy-Unit/nhp_data/blob/add_demographics/inputs_data/op/init.py#L39](in the op file) to exclude type == "maternity"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
techdebt Make hastily-written code easier to maintain
Projects
None yet
Development

No branches or pull requests

3 participants