Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.2] Wither music also plays on wither skeletons #160

Open
spectre311 opened this issue Feb 4, 2024 · 1 comment
Open

[1.19.2] Wither music also plays on wither skeletons #160

spectre311 opened this issue Feb 4, 2024 · 1 comment
Labels
enhancement New feature or request ETA: 7.0 Planned fix or feature for 7.0 WIP Some progress has been made regarding this without necessarily confirming a fix

Comments

@spectre311
Copy link

Describe the bug
So when i added music for the wither fight, it also detected wither skeletons for some reason. Might be cause it's name starts with wither.

To Reproduce
Steps to reproduce the behavior: Just add music to the wither

@TheComputerizer
Copy link
Owner

That would be correct as resource_name parameters are allowed to partially match in most cases and minecraft:wither is contained in minecraft:wither_skeleton. However ,the mob trigger is also able to check for display names which must match exactly. Setting the resource_name = [ "Wither" ] should work for the display name, but since the wither is also a boss you can utilize the BOSS case like resource_name = [ "BOSS" "Wither" ].

Boss whitelisting also follows the partial matching/exact matching conventions between the mob id & display names with the caveat that there needs to be a boss bar so it shouldn't pick up wither skeletons regardless.

While this isn't an issue, it is related to an enhancement planned for 7.0 regarding the resource_name parameter so I'll leave this open.

@TheComputerizer TheComputerizer added enhancement New feature or request ETA: 7.0 Planned fix or feature for 7.0 WIP Some progress has been made regarding this without necessarily confirming a fix labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ETA: 7.0 Planned fix or feature for 7.0 WIP Some progress has been made regarding this without necessarily confirming a fix
Projects
None yet
Development

No branches or pull requests

2 participants