You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I always forget that GitHub has discussions now 😅
So, reproducing what I sent on Discord:
Hi folks! I am in a quest to reduce Moonlight's audio latency, but while debugging the app I kept running into exceptions, NPE and other crashes. I have a branch that should fix all the issues I ran into, along with multiple memory leaks. Are you folks interested in having the fixes upstream? I suppose so, but I did not find a contributing readme in the repo to know where to start. Like, should I open a big PR with all fixes, or one PR per fix? They are all in the C++ codebase of the repo by the way.
By the way, in one of my changes I moved the project from C++14 to C++17 to have access to std::string_view, an optimization. Would it be OK to move it to 17, or it should be kept at 14? If 14 is a must then I need to revert it.
So, this discussion is mostly to ask about a possible C++14 to C++17 upgrade. Would that be OK? I am preparing some branches to open PRs with my fixes.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I always forget that GitHub has discussions now 😅
So, reproducing what I sent on Discord:
So, this discussion is mostly to ask about a possible C++14 to C++17 upgrade. Would that be OK? I am preparing some branches to open PRs with my fixes.
Beta Was this translation helpful? Give feedback.
All reactions