Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros should declare version compatibility #43

Open
revilowaldow opened this issue Sep 16, 2022 · 1 comment
Open

Macros should declare version compatibility #43

revilowaldow opened this issue Sep 16, 2022 · 1 comment

Comments

@revilowaldow
Copy link
Contributor

  • Macros should declare version compatibility
    • Does Item Macro already do this?
  • Can multiple macros be defined to allow the importer to pick the appropriate version, or should the macro itself have multi-version support?
    • The intent seems to be for this module to support multiple versions re v10 Support #42
  • The module should only import/apply macros that are compatible with the version it's currently running on
  • The module should never import macros that are outside the compatibility range of the module itself??
@Spappz
Copy link
Collaborator

Spappz commented Sep 16, 2022

Does Item Macro already do this?

No

Can multiple macros be defined to allow the importer to pick the appropriate version, or should the macro itself have multi-version support?

I'd say that we should only aim to support latest version (plus usual leeway for module catch-up), but realistically most macros shouldn't be that complex. If a macro is being broken every single update, I think there's an issue with that macro; the vast majority will be just simple actor.data.data updates, so as long as we don't have another de-data.data-ing then I think things will mostly be fine.

The module should only import/apply macros that are compatible with the version it's currently running on

Or give the option whether to import or skip (potentially as a catch-all module setting rather than a per-import prompt). Some people like the risk I guess 🥴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants