Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Rampage, Flurry, and Unbridled Wrath should be handled as generic "hit effects" #34

Open
vigo2 opened this issue Jun 16, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@vigo2
Copy link

vigo2 commented Jun 16, 2021

I'd propose something along

interface Buff {
   ApplyOrRefresh(duration, simTime, simState)
   MaybeRemove(simTime, simState)
}

interface Proc {
   OnHit(hitState, simTime, simState)
}

with the various supported procs and buffs/debuffs being simple script-like implementations. This allows to remove a ton of global or near global ("manager") state, keeps the various "swing()"-like methods clean, and removes the runtime overhead of perpetually checking for non-existing procs or buffs.

@TheGroxEmpire TheGroxEmpire self-assigned this Jun 16, 2021
@TheGroxEmpire TheGroxEmpire added the enhancement New feature or request label Jun 16, 2021
@vigo2 vigo2 changed the title [enhancement] Rampage, Flurry, and Unbridled Wrath should be handled as generic "hit effects" Rampage, Flurry, and Unbridled Wrath should be handled as generic "hit effects" Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants