Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests refactoring #419

Closed
carlwr opened this issue Dec 27, 2023 · 1 comment · Fixed by #442
Closed

Integration tests refactoring #419

carlwr opened this issue Dec 27, 2023 · 1 comment · Fixed by #442
Assignees
Labels
development Changes related to development (utilities, tests, CI/CD)

Comments

@carlwr
Copy link

carlwr commented Dec 27, 2023

I was considering contributing some refactoring of the integration tests; something like speeding them up (there's some low hanging fruit there), adding some structure, dropping the unittest imports in favour of pytest functionality and incorporating some other testing best practices. I also see a possibility of reducing the test code LOC (without testing less).

Would such a PR be welcome?

If so, any other guidelines/preferences around the tests that could be useful for me to know in advance?

@TheR1D

@TheR1D
Copy link
Owner

TheR1D commented Dec 27, 2023

Would be great to refactor current tests, since they are not well written. LOC code optimisations are always welcome. There are few resources might be usefull:

We also have a unit test module where we can add more tests with mocked responses (as OpenAI tests).

@TheR1D TheR1D added the development Changes related to development (utilities, tests, CI/CD) label Dec 27, 2023
@TheR1D TheR1D self-assigned this Jan 14, 2024
@TheR1D TheR1D linked a pull request Jan 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Changes related to development (utilities, tests, CI/CD)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants