Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Table element styling #61

Open
TheWebTech opened this issue May 14, 2019 · 5 comments
Open

Create Table element styling #61

TheWebTech opened this issue May 14, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@TheWebTech
Copy link
Owner

TheWebTech commented May 14, 2019

Create simple but visually decent table element styling. I suggest making a codepen and trying to build out a table there so you can see what you think. (if you do make a codepen, please share it here so we can see it)

This task is for specifically base table styling.

Mobile, modifiers and any other special functionality can come later, don't worry about that right now. We just need base table tr td thead type styling set up. If you WANT to do more go for it, it's just not expected.

All of the styling for the table element can go in cs-defaults.

If you want an example of what this could look like
https://getbootstrap.com/docs/4.0/content/tables/
https://foundation.zurb.com/sites/docs/table.html

@TheWebTech TheWebTech added the enhancement New feature or request label May 14, 2019
@dennisedson
Copy link

getting started here:
https://codepen.io/billyoncetoldme/pen/BepyNR

@TheWebTech
Copy link
Owner Author

lookin' good! Seriously

@TheWebTech
Copy link
Owner Author

Something we haven't ever discussed and I don't know if it's actually a big deal - Twitter bootstrap makes it so a css class enables the table styles(the thought being in-case any plugin js or anything generates a table, then the styles wouldn't conflict)

obviously your base element tweaks aren't ones that are really going to cause something like that to get really weird

Personally though I do like that if they're based on the base table element it will work for marketers just adding tables in the hubspot rich text editors

@adesignl
Copy link
Collaborator

adesignl commented May 14, 2019 via email

@TheWebTech
Copy link
Owner Author

Just moved this issue to make it clear Dennis has started on this.

lol Chad your email signature with your meeting scheduling phone number and email address is pulling through to the github issues.

Not a problem from our end, but you might get robo calls, spam emails, and Dennis scheduling a meeting with you

@TheWebTech TheWebTech added this to the v1.1 - Components milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants