Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modals #71

Open
TheWebTech opened this issue May 14, 2019 · 0 comments
Open

Add Modals #71

TheWebTech opened this issue May 14, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone
v1.1 - Base Compo...

Comments

@TheWebTech
Copy link
Owner

TheWebTech commented May 14, 2019 •
edited
Loading

Modals are a common UI

I think we should have a standard modal we implement.

Initially we could role with just using Magnific or something but long term I'd like to use native modals <dialog> because they come with automatic accessibility and semantic benefits.
Additional accessibility stuff:
https://github.com/edenspiekermann/a11y-dialog

We should have a class or something that when that element is clicked triggers the modal.

CSS for this should go in cs-defaults.css
@TheWebTech TheWebTech added the enhancement New feature or request label May 14, 2019
@TheWebTech TheWebTech added this to the v1.1 - Components milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1 - Base Components
Development

No branches or pull requests
1 participant
@TheWebTech