Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data / Network 리펙토링 #144

Open
42 tasks done
minsangKang opened this issue Mar 24, 2024 · 0 comments · May be fixed by #163
Open
42 tasks done

Data / Network 리펙토링 #144

minsangKang opened this issue Mar 24, 2024 · 0 comments · May be fixed by #163
Assignees
@minsangKang
Labels
feature 기능 추가/변경/삭제
Milestone
[iOS] 회원 관리 기능

Comments

@minsangKang
Copy link
Member

minsangKang commented Mar 24, 2024 •
edited
Loading

Tech Spec

Moya를 사용한 Network Layer 구축

Background | Issue 발행 배경

TiTi 백엔드와 연결을 위해 Moya 라이브러리를 도입하여 새롭게 Network Layer를 구축한다.

Acceptance Criteria | 허용 기준

Given(조건, 상황) | When(행동) | Then(결과)

  • Moya 라이브러리 추가
  • TTPovider 생성 (기본 Error 핸들링)
  • 각 API를 Moy 형식으로 리펙토링
    • FirebaseAPI
    • AuthAPI
    • DailysAPI
  • CombineMoya 기반 각 Repository 리펙토링 (반환: AnyPublisher<Model, NetworkError>)
    • AppLatestVersionRepository -> FirebaseRepository
    • ServerURLRepository -> FirebaseRepository
    • AuthRepository -> AuthRepository
    • DailysRepository -> DailysRepository
    • RecordTimesRepository -> RecordTimesRepository
    • SyncLogRepository -> SyncLogRepository
    • NotificationRepository
  • Request 폴더 추가
  • DTO 폴더 삭제 -> Response 폴더 추가
  • NetworkError 리펙토링 (statusCode 기반 Error 반환, 신규서버 Error객체 기반 Error 반환)
    • TTErrorResponse 생성
    • TTResponse 생성
  • Publisher 기반 UseCase 생성 및 구현
    • GetAppVersionUseCase 생성 & 반영
    • GetServerURLUseCasee 생성 & 반영
    • GetTiTiFunctionsUseCase 생성 & 반영
    • GetUpdateHistorysUseCase 생성 & 반영
    • GetYoutubeLinkUseCase 생성 & 반영
    • GetSurveysUseCase 생성 & 반영
    • GetNotificationUseCase 생성 & 반영
    • SignupUseCase 생성 & 반영
    • SigninUseCase 생성 & 반영
    • CheckUsernameExitUseCsae 생성 & 반영
    • CheckEmailExitUseCase 생성 & 반영
    • UpdatePasswordUseCase 생성 & 반영
    • GetDailysUseCase 생성 & 반영
    • PostDailysUseCase 생성 & 반영
    • PostRecordTimeUseCase 생성 & 반영
    • GetRecordTimeUseCase 생성 & 반영
    • GetSyncLogUseCase 생성 & 반영
  • NetworkController 클래스 삭제
  • Network 클래스 삭제
  • Network 사용하는 모든 VM단 리펙토링 반영
    • 신규 UseCase로 변경
    • Publisher 기반 수신 구현
@minsangKang minsangKang added the feature 기능 추가/변경/삭제 label Mar 24, 2024
@minsangKang minsangKang self-assigned this Mar 24, 2024
@minsangKang minsangKang added this to TiTi Mar 24, 2024
@github-project-automation github-project-automation bot moved this to Backlog in TiTi Mar 24, 2024
@minsangKang minsangKang moved this from Backlog to Ready in TiTi Mar 24, 2024
@minsangKang minsangKang moved this from Ready to In progress in TiTi Apr 17, 2024
minsangKang added a commit that referenced this issue Apr 17, 2024
@minsangKang
feat #144: FirebaseAPI 생성
5202740
minsangKang added a commit that referenced this issue Apr 17, 2024
@minsangKang
feat #144: AuthAPI 생성
683a42d
minsangKang added a commit that referenced this issue Apr 17, 2024
@minsangKang
feat #144: DailysAPI 생성
f15f162
minsangKang added a commit that referenced this issue Apr 17, 2024
@minsangKang
update #144: AuthAPI: task 수정
d61a4e3
minsangKang added a commit that referenced this issue Apr 27, 2024
@minsangKang
feat #144: FirebaseAPI 생성
f3fb50e
minsangKang added a commit that referenced this issue Apr 27, 2024
@minsangKang
feat #144: AuthAPI 생성
cbcf064
minsangKang added a commit that referenced this issue Apr 27, 2024
@minsangKang
feat #144: DailysAPI 생성
3a250c0
minsangKang added a commit that referenced this issue Apr 27, 2024
@minsangKang
update #144: AuthAPI: task 수정
237ee3e
minsangKang added a commit that referenced this issue Apr 30, 2024
@minsangKang
feat #144: FirebaseAPI 생성
2675fd8
minsangKang added a commit that referenced this issue Apr 30, 2024
@minsangKang
feat #144: AuthAPI 생성
6072374
minsangKang added a commit that referenced this issue Apr 30, 2024
@minsangKang
feat #144: DailysAPI 생성
234bec5
minsangKang added a commit that referenced this issue Apr 30, 2024
@minsangKang
update #144: AuthAPI: task 수정
0d80edf
minsangKang added a commit that referenced this issue May 15, 2024
@minsangKang
feat #144: getAppVersion RxMoya 방식 반영중
e0f559d
minsangKang added a commit that referenced this issue May 15, 2024
@minsangKang
feat #144: getAppVersion RxMoya 방식 구현
f554462
minsangKang added a commit that referenced this issue May 22, 2024
@minsangKang
feat #144: getServerURL RxMoya 방식 구현
8c90a07
minsangKang added a commit that referenced this issue May 22, 2024
@minsangKang
feat #144: postSignup RxMoya 방식 구현
1bdfc68
@minsangKang minsangKang changed the title Data / Network 구축 Data / Network 리펙토링 May 26, 2024
minsangKang pushed a commit that referenced this issue May 31, 2024
@ios-minsang @minsangKang
feat #144: CombineMoya 방식으로 수정 & AuthRepository 구현
60adb45
minsangKang added a commit that referenced this issue May 31, 2024
@minsangKang
feat #144: CombineMoya 방식으로 수정 & AuthRepository 구현
c6aa580
minsangKang added a commit that referenced this issue Jun 9, 2024
@minsangKang
feat #144: 200대 statusCode가 아닌 경우 ErrorResponse 값 반환 구현
e35e4ad
minsangKang added a commit that referenced this issue Jun 9, 2024
@minsangKang
feat #144: 200대 statusCode가 아닌 경우 ErrorResponse 값 반환 구현
f80e638
minsangKang added a commit that referenced this issue Jun 9, 2024
@minsangKang
rename #144: Info -> Request 명칭 수정
3435112
minsangKang added a commit that referenced this issue Jun 9, 2024
@minsangKang
feat #144: DailysRepository 구현
51f480a
minsangKang added a commit that referenced this issue Jun 29, 2024
@minsangKang
refact #144: DTO 폴더 삭제, Response 및 info로 분리
dccb6d2
minsangKang added a commit that referenced this issue Jun 29, 2024
@minsangKang
chore #144: 디렉토리 리펙토링
c8bb161
minsangKang added a commit that referenced this issue Jun 29, 2024
@minsangKang
chore #144: 기존 UseCase들 lagacy 폴더로 이동
138d552
minsangKang added a commit that referenced this issue Jun 29, 2024
@minsangKang
feat #144: NetworkController 내 함수들 FirebaseRepository 내 반영
1a7e0db
minsangKang added a commit that referenced this issue Jun 29, 2024
@minsangKang
feat #144: FirebaseUseCase 생성
60b8304
minsangKang added a commit that referenced this issue Jun 29, 2024
@minsangKang
feat #144: Firebase 관련 UseCase 생성
c367b9c
minsangKang added a commit that referenced this issue Jun 30, 2024
@minsangKang
feat #144: GetAppVersionUseCase 반영
e83bd72
minsangKang added a commit that referenced this issue Jun 30, 2024
@minsangKang
delete #144: 불필요파일 제거
ec27002
minsangKang added a commit that referenced this issue Jun 30, 2024
@minsangKang
feat #144: GetServerURLUseCase 반영
a1531f5
minsangKang added a commit that referenced this issue Jun 30, 2024
@minsangKang
delete #144: 불필요파일 제거
b77f417
minsangKang added a commit that referenced this issue Jul 6, 2024
@minsangKang
feat #144: GetTiTiFunctionsUseCase 반영
ebb5afa
minsangKang added a commit that referenced this issue Jul 6, 2024
@minsangKang
fix #144: TTProvider의 request를 사용하도록 수정, map operator 생성
9c517cb
minsangKang added a commit that referenced this issue Jul 6, 2024
@minsangKang
feat #144: GetUpdateHistorysUseCase 반영
89c5ef3
minsangKang added a commit that referenced this issue Jul 6, 2024
@minsangKang
feat #144: GetSurveysUseCase 반영
fd8ef4d
minsangKang added a commit that referenced this issue Jul 6, 2024
@minsangKang
feat #144: AuthRepository 관련 UseCase들 생성
e550310
minsangKang added a commit that referenced this issue Jul 6, 2024
@minsangKang
feat #144: SignupUseCase, SigninUseCase 반영
9238ebc
minsangKang added a commit that referenced this issue Jul 6, 2024
@minsangKang
feat #144: CheckUsernameExitUseCase 반영
0a65a67
minsangKang added a commit that referenced this issue Jul 7, 2024
@minsangKang
feat #144: GetDailysUseCase 셍성 & 반영
d4e899f
minsangKang added a commit that referenced this issue Jul 7, 2024
@minsangKang
feat #144: 나머지 UseCase들 생성
2c2ca7a
minsangKang added a commit that referenced this issue Jul 7, 2024
@minsangKang
fix #144: statusCode에 따른 NetworkError가 그대로 전달되도록 수정
3091d08
minsangKang added a commit that referenced this issue Aug 10, 2024
@minsangKang
feat #144: UploadDailys 동작 구현, header 를 통해 gmt 전달 구현
9e8cd74
minsangKang added a commit that referenced this issue Aug 11, 2024
@minsangKang
feat #144: GetNotificationUseCase 반영
4d76aa8
minsangKang added a commit that referenced this issue Aug 11, 2024
@minsangKang
feat #144: CheckEmailExitUseCase, UpdatePasswordUseCase 반영
c98a398
minsangKang added a commit that referenced this issue Aug 11, 2024
@minsangKang
feat #144: Post & GetRecordTimeUseCase, GetSyncLogUseCase 반영
c0d0892
minsangKang added a commit that referenced this issue Aug 11, 2024
@minsangKang
feat #144: Network 클래스 제거, 리펙토링 완료
7a357a2
@minsangKang minsangKang linked a pull request Aug 11, 2024 that will close this issue
Open
2 tasks
@minsangKang minsangKang linked a pull request Aug 11, 2024 that will close this issue
Moya 및 Combine을 사용한 Network 리펙토링 #163
Open
2 tasks
minsangKang added a commit that referenced this issue Nov 24, 2024
@minsangKang
feat #144: 코드리뷰-버전정보 수신오류시 팝업 표시
10b99ef
minsangKang added a commit that referenced this issue Nov 24, 2024
@minsangKang
feat #144: 코드리뷰-extension TargetType static 제거
bc51802
minsangKang added a commit that referenced this issue Nov 24, 2024
@minsangKang
feat #144: 코드리뷰-uppercase 변수명 lowercase 수정
aa72f11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minsangKang minsangKang

Labels
feature 기능 추가/변경/삭제
Projects
TiTi
Status: In progress
Milestone
[iOS] 회원 관리 기능
Development

Successfully merging a pull request may close this issue.

Moya 및 Combine을 사용한 Network 리펙토링 TimerTiTi/TiTi_iOS
1 participant
@minsangKang