Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communications module: implement new broadcast object method #210

Open
Ellypse opened this issue Aug 24, 2018 · 0 comments
Open

Communications module: implement new broadcast object method #210

Ellypse opened this issue Aug 24, 2018 · 0 comments

Comments

@Ellypse
Copy link
Member

Ellypse commented Aug 24, 2018

Some recent fixes made the sendObject method dynamically adapt to sending something to one person via whisper or broadcasting on a channel.

In favour of clarity and explicit usage, we instead want to add a broadcastObject method to the Communications module that will only handle broadcasting something on a specified channel.

Some code can be refactored and shared between this new function and the sendObject one. Existing usage of sendObject to broadcast data will have to be updated to use the new function.

@Ellypse Ellypse added this to the 1.5.0 milestone Aug 24, 2018
@Ellypse Ellypse modified the milestones: 1.5.0, 1.5.1 Oct 24, 2018
@Ellypse Ellypse removed this from the 1.5.1 milestone Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant