From c5051797309b161f450800a3110432d674649d68 Mon Sep 17 00:00:00 2001 From: alvarosabu Date: Wed, 5 Feb 2025 20:07:05 +0100 Subject: [PATCH] fix: safely remove helpers in vDistanceTo and vLightHelper directives --- src/directives/vDistanceTo.ts | 4 +++- src/directives/vLightHelper.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/directives/vDistanceTo.ts b/src/directives/vDistanceTo.ts index 7eacfd988..6b416fcc0 100644 --- a/src/directives/vDistanceTo.ts +++ b/src/directives/vDistanceTo.ts @@ -33,6 +33,8 @@ export const vDistanceTo = { }, unmounted: (el: TresObject) => { arrowHelper?.dispose() - el.parent.remove(arrowHelper) + if (el.parent) { + el.parent.remove(arrowHelper) + } }, } diff --git a/src/directives/vLightHelper.ts b/src/directives/vLightHelper.ts index 9a14f1fe5..512996c67 100644 --- a/src/directives/vLightHelper.ts +++ b/src/directives/vLightHelper.ts @@ -56,6 +56,8 @@ export const vLightHelper = { if (currentInstance && currentInstance.dispose) { currentInstance.dispose() } - el.parent.remove(currentInstance) + if (el.parent) { + el.parent.remove(currentInstance) + } }, }