Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-demand invalidation not triggered when assets are loaded. #909

Closed
5 tasks done
alvarosabu opened this issue Jan 24, 2025 · 1 comment
Closed
5 tasks done

on-demand invalidation not triggered when assets are loaded. #909

alvarosabu opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
p4-important-bug Violate documented behavior or significantly improve performance (priority)

Comments

@alvarosabu
Copy link
Member

Describe the bug

We should automatically invalidate when useTexture resolves the textures fetching. Is not really noticeable on the reproduction but I have a asset heavy demo that occurs

Screen.Recording.2025-01-24.at.11.16.22.mov

Reproduction

https://stackblitz.com/~/edit/tresjs-minimal-reproduction-sht9ttt5?file=src/App.vue

Steps to reproduce

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @tresjs/cientos: 4.1.0 => 4.1.0 
    @tresjs/core: 4.3.2 => 4.3.2 
    @tresjs/leches: ^0.14.0 => 0.14.0 
    vite: ^6.0.3 => 6.0.5

Used Package Manager

pnpm

Code of Conduct

@alvarosabu alvarosabu self-assigned this Jan 24, 2025
@alvarosabu alvarosabu added the p4-important-bug Violate documented behavior or significantly improve performance (priority) label Jan 24, 2025
@alvarosabu
Copy link
Member Author

I will close this since the current usage of useTexture and useLoader is not aligned with what a vue composable should be. For now, invalidation needs tobe called by the user after resources are loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important-bug Violate documented behavior or significantly improve performance (priority)
Projects
Status: Done
Development

No branches or pull requests

1 participant