-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker run doesn't work with tini #91
Comments
I hit the same thing! |
"What JEmershaw Meant to say is", While running: The Container fails to start because of the following: |
I ran into this a while ago too and filed https://smartos.org/bugview/OS-5615 internally. I've linked the two tickets now. |
This upgrades Tini to 0.13.1 in order to fix a compatibility issue with https://github.com/joyent/sdc-docker (see: TritonDataCenter/sdc-docker#91). The fix itself was provided by @geek of Joyent. I've also made the Tini architecture more explicit (since Tini now also supports ARM), so in case you decide to support additional architectures in the future, the fix should be more obvious. There isn't much functional difference between 0.9.0 (which you were using) and 0.13.1, but here are a few notable changes you might care about to some extent: - Tini now supports a `-l` flag to show its license. This was useful from a compliance perspective for some users (so considering you're shipping Tini that might indirectly be useful to you!). - Tini now supports a `--version` argument to show its version. This is here mostly because it's a little more intuitive than what was there before (you'd have to use `-h` to see the version). - Tini now supports a `TINI_VERBOSITY` environment variable (should be an int), which can be convenient for debugging when Tini is used as an `ENTRYPOINT` (avoids the need to alter the entrypoint to configure it). - Tini now uses more specific exit codes when it fails to fork (e.g. because the binary you're looking for doesn't exist, etc.).
This upgrades Tini to 0.13.1 in order to fix a compatibility issue with https://github.com/joyent/sdc-docker (see: TritonDataCenter/sdc-docker#91). The fix itself was provided by @geek of Joyent. I've also made the Tini architecture more explicit (since Tini now also supports ARM), so in case you decide to support additional architectures in the future, the fix should be more obvious. There isn't much functional difference between 0.9.0 (which you were using) and 0.13.1, but here are a few notable changes you might care about to some extent: - Tini now supports a `-l` flag to show its license. This was useful from a compliance perspective for some users (so considering you're shipping Tini that might indirectly be useful to you!). - Tini now supports a `--version` argument to show its version. This is here mostly because it's a little more intuitive than what was there before (you'd have to use `-h` to see the version). - Tini now supports a `TINI_VERBOSITY` environment variable (should be an int), which can be convenient for debugging when Tini is used as an `ENTRYPOINT` (avoids the need to alter the entrypoint to configure it). - Tini now uses more specific exit codes when it fails to fork (e.g. because the binary you're looking for doesn't exist, etc.). Thanks for using Tini in this image!
PR for official jenkins image to upgrade their tini version: jenkinsci/docker#394 I verified this works... here is a working image: https://hub.docker.com/r/d0cker/jenkins/ |
This upgrades Tini to 0.13.1 in order to fix a compatibility issue with https://github.com/joyent/sdc-docker (see: TritonDataCenter/sdc-docker#91). The fix itself was provided by @geek of Joyent. I've also made the Tini architecture more explicit (since Tini now also supports ARM), so in case you decide to support additional architectures in the future, the fix should be more obvious. There isn't much functional difference between 0.9.0 (which you were using) and 0.13.1, but here are a few notable changes you might care about to some extent: - Tini now supports a `-l` flag to show its license. This was useful from a compliance perspective for some users (so considering you're shipping Tini that might indirectly be useful to you!). - Tini now supports a `--version` argument to show its version. This is here mostly because it's a little more intuitive than what was there before (you'd have to use `-h` to see the version). - Tini now supports a `TINI_VERBOSITY` environment variable (should be an int), which can be convenient for debugging when Tini is used as an `ENTRYPOINT` (avoids the need to alter the entrypoint to configure it). - Tini now uses more specific exit codes when it fails to fork (e.g. because the binary you're looking for doesn't exist, etc.). Thanks for using Tini in this image!
Jenkins uses tini to start the jenkins container, this doesn't seem to work using triton/docker.
The text was updated successfully, but these errors were encountered: