Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MI-02 Protocol Deviations Could Lead To Attacks #74

Open
xoloki opened this issue May 15, 2024 · 0 comments
Open

MI-02 Protocol Deviations Could Lead To Attacks #74

xoloki opened this issue May 15, 2024 · 0 comments
Assignees
Labels

Comments

@xoloki
Copy link
Collaborator

xoloki commented May 15, 2024

the FROST paper there are a few instances in which strings are concatenated and then hashed to be used as commitments. Sometimes, this implementation changes the order in which strings are concatenated. While this may probably have no security impact, we suggest following the paper for soundness and to prevent library collaborators from misusing these.
The order of R and aG is reversed with respect to the FROST paper in the calculation of c=Hash(ID...) and it is missing the common reference string. Again, while replay attacks may be prevented with the use of dkg_id, the impact of this seemingly small protocol deviation grows in view of Issue HI-02.
Again the order of Hash(R Y m) in this library is different from the FROST paper.
While this is most probably not an issue, it presents the implementers and others with questions that could be avoided.

@xoloki xoloki added the audit label May 15, 2024
@xoloki xoloki self-assigned this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant