Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MI-06 Inconsistent Configuration #78

Open
xoloki opened this issue May 15, 2024 · 1 comment
Open

MI-06 Inconsistent Configuration #78

xoloki opened this issue May 15, 2024 · 1 comment
Assignees
Labels

Comments

@xoloki
Copy link
Collaborator

xoloki commented May 15, 2024

The Config class in coordinator/mod.rs method new() includes the following line signer_public_keys: HashMap<u32, Point>,
However, later the in net.rs the object public keys is different:

pub struct PublicKeys {
   /// signer_id -> public key
   pub signers: HashMap<u32, ecdsa::PublicKey>,
   /// key_id -> public key
   pub key_ids: HashMap<u32, ecdsa::PublicKey>,
}

This inconsistency is not caught in tests (for example, of the Packet method validate() which would catch this error) but this could lead to problems for typical use cases.

@xoloki xoloki added the audit label May 15, 2024
@xoloki xoloki self-assigned this May 15, 2024
@xoloki
Copy link
Collaborator Author

xoloki commented Dec 19, 2024

This is addressed in the library level handing of CR-01/02 (#66 #67).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant