Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need the timeframe structure? #715

Open
datejada opened this issue Jul 31, 2024 · 0 comments
Open

Do we need the timeframe structure? #715

datejada opened this issue Jul 31, 2024 · 0 comments
Labels
Type: improvement Better way of doing something Zone: data & import Interfacing between database and Julia

Comments

@datejada
Copy link
Member

What and Why

timeframe saves the whole DataFrame, but we shouldn’t do that. We want only what it actually needs, or use DuckDB table instead, so we avoid this part of the code and its dependencies.

timeframe = Timeframe(num_periods, TulipaIO.get_table(connection, "rep_periods_mapping"))

Possible Drawbacks

No response

Related Issues

No response
@datejada datejada added Type: improvement Better way of doing something Zone: data & import Interfacing between database and Julia labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: improvement Better way of doing something Zone: data & import Interfacing between database and Julia
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@datejada