Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change events trigger immediate render calls #8

Open
Beanow opened this issue Dec 10, 2014 · 0 comments
Open

Change events trigger immediate render calls #8

Beanow opened this issue Dec 10, 2014 · 0 comments

Comments

@Beanow
Copy link

Beanow commented Dec 10, 2014

Currently the base-store provides a change event which triggers immediately when the internal data has been updated. However, for actions that span multiple entities, each store will trigger this event before all stores are updated.

This causes for ugly rendering methods that check for stores that are not done processing the action yet. The principles document for Actions states that:

...stores should never be in an inconsistent state after the dispatcher has dispatched an Action.

Note that this says, after the dispatcher has dispatched an Action, not during.
I think stores should wait until dispatching has completed before triggering the change event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant