Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number in metadata file and updating the versions #128

Open
kripanshu opened this issue May 8, 2018 · 1 comment
Open

Version number in metadata file and updating the versions #128

kripanshu opened this issue May 8, 2018 · 1 comment
Assignees

Comments

@kripanshu
Copy link
Contributor

For custom_statistics:
When we update statistics on a given version let's say ( version: 1.1 ), it increases the number to +1 => version: 1.2
this is true only when 1.1 is the latest version, i.e there are no upper versions like ( 1.2,1.3 etc.)
But if there is a scenario where a file has
preprocess_id : 1, versions: 1.1,1.2,1.3. Now here we update statistics of the version 1.1 which should give version 1.4. But the metadata file is setting it's version 1.2 and database is setting it to 1.4

@kripanshu kripanshu changed the title Version number in metadata file and database different Version number in metadata file and updating the versions May 8, 2018
@kripanshu
Copy link
Contributor Author

In theory:

  • the person can always view their older versions
  • make updates/deletes to change the latest back to an older version
    So any updates always are against the latest.
    but: don't change anything yet

Scenario:

  • these versions exist: 1, 1.1, 1.2, 1.3
  • the user has 2 editors open (editor being what UT is working on)
  • one editor has version 1.3
  • another browser window has version 1.1 loaded (somehow left it open by accident)
  • If the user submits an update from the 1.1 version, we should reject it (edited)
    In other words, the updates should include the version to update--but this is only to check if it's the latest version

Shorter version - Same Scenario

  • these versions exist: 1, 1.1, 1.2, 1.3
  • update to 1.3 goes through
  • update to 1, 1.1, or 1.2 fails b/c these aren't the latest version

This error should be rare but is definitely possible

by @raprasad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants