Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved context ergonomics #2

Open
TylerBloom opened this issue Jan 14, 2024 · 0 comments
Open

Improved context ergonomics #2

TylerBloom opened this issue Jan 14, 2024 · 0 comments

Comments

@TylerBloom
Copy link
Owner

Currently, the WebTerminal's component Context is passed directly into the TerminalApp methods. While functional, this poses a few ergonomics problems.

First, creating callbacks is much more annoying. The return value of the callback's closure is implicitly converted into the component's message type; however, there is a layer of abstraction between the terminal app's message type and the web terminal message type. This requires the callback creator to either create their message type or construct a web terminal message. Ideally, this same implicit conversion behavior can be maintained.

Second, there is currently no way for the terminal app to access the terminal or the terminal backend. Ideally, this would be accessible via the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant