You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Came across with the project accidentally (actually use TypeForm API in production (but my own implementation)).
After reading the code, I decided that it should be refactored a little, as I noticed many cases that, in my opinion, need to be rewritten:
functions in utils seem to me pretty strange and even a little redundant (e.g. mergeDict: since starting with python 3.9 it's enought to use "|" for dicts union), naming of the functions etc.
PEP-8 violations: naming of variables (it is preferable to use lower case with underscores), max line length, docstrings, etc
There are unused constants in constants.py. And actually it seems like it's better to name it settings.py instead.
string formatting. Much more readable (IMHO) use f-strings there (since python 3.6)
actually already have a commit with all these changes: 7910ba4
So I can make a PR
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Came across with the project accidentally (actually use TypeForm API in production (but my own implementation)).
After reading the code, I decided that it should be refactored a little, as I noticed many cases that, in my opinion, need to be rewritten:
actually already have a commit with all these changes: 7910ba4
So I can make a PR
The text was updated successfully, but these errors were encountered: