Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how the app imports the base GOV.UK scss files #2

Open
3 tasks
tomfitzherbert opened this issue Jan 3, 2018 · 0 comments
Open
3 tasks

Fix how the app imports the base GOV.UK scss files #2

tomfitzherbert opened this issue Jan 3, 2018 · 0 comments

Comments

@tomfitzherbert
Copy link
Contributor

tomfitzherbert commented Jan 3, 2018 •
edited
Loading

Description

The application isn't currently picking up some of the .scss from the GOV.UK packages. It currently uses a pre-baked .css file to workaround this issue.

Acceptance criteria

  • The application should correctly import the scss files from the npm packages and use these as the sources via the node-sass-middleware.
  • The temporary style.css file has been removed
  • All web pages still render correctly
hemantgoswami added a commit that referenced this issue Mar 14, 2019
@hemantgoswami
Updates drone config #2
5bd7f83
hemantgoswami added a commit that referenced this issue Mar 14, 2019
@hemantgoswami
Secures application by: (#23)
7ff649c 
* Secures application by:
1) Only displaying errors that are alright to be viewed in prod
2) Redirects stack traces to log and brings user back to home page
3) Removes environment variable set that confuses with NODE_ENV which is the one node uses by default

* Removes duplicate lines

* Updates drone config

* Updates drone config #2
hemantgoswami added a commit that referenced this issue Dec 23, 2019
@hemantgoswami
Updates the keycloak config #2
e0260c7
hemantgoswami added a commit that referenced this issue Aug 21, 2024
@hemantgoswami
debugging BDM #2
49bf58b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomfitzherbert