From bf6f64b1ad3c6678fa27fb12de4dd001890c803a Mon Sep 17 00:00:00 2001
From: Sam <51686767+samuveth@users.noreply.github.com>
Date: Tue, 28 Nov 2023 13:06:09 +0700
Subject: [PATCH 1/3] fix: Validate space settings on proposal creation (#4403)

Co-authored-by: Wan <495709+wa0x6e@users.noreply.github.com>
---
 src/components/SpaceCreateWarnings.vue | 7 +++++++
 src/views/SpaceCreate.vue              | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/components/SpaceCreateWarnings.vue b/src/components/SpaceCreateWarnings.vue
index bd32ebf9..329491b5 100644
--- a/src/components/SpaceCreateWarnings.vue
+++ b/src/components/SpaceCreateWarnings.vue
@@ -5,6 +5,7 @@ const props = defineProps<{
   space: ExtendedSpace;
   validationFailed: boolean;
   isValidAuthor: boolean;
+  isValidSpace: boolean;
   validationName: string;
   containsShortUrl: boolean;
 }>();
@@ -43,6 +44,12 @@ const strategySymbolsString = computed(() => {
   <div class="mb-4 space-y-2">
     <MessageWarningHibernated v-if="space.hibernated" :space="space" />
 
+    <BaseMessageBlock v-else-if="!isValidSpace" level="warning">
+      Proposal creation is blocked due to invalid space settings. Please contact
+      a space admin or if you are an admin head over to the settings page and
+      save them again.
+    </BaseMessageBlock>
+
     <MessageWarningGnosisNetwork
       v-else-if="isGnosisAndNotSpaceNetwork"
       :space="space"
diff --git a/src/views/SpaceCreate.vue b/src/views/SpaceCreate.vue
index 3cce1e3c..00c1d6f3 100644
--- a/src/views/SpaceCreate.vue
+++ b/src/views/SpaceCreate.vue
@@ -47,6 +47,8 @@ const { isGnosisAndNotSpaceNetwork } = useGnosis(props.space);
 const { isSnapshotLoading } = useSnapshot();
 const { apolloQuery, queryLoading } = useApolloQuery();
 const { containsShortUrl } = useShortUrls();
+const { isValid: isValidSpaceSettings, populateForm } =
+  useFormSpaceSettings('settings');
 
 const {
   form,
@@ -405,6 +407,8 @@ onBeforeRouteLeave(async () => {
     resetForm();
   }
 });
+
+onMounted(() => populateForm(props.space));
 </script>
 
 <template>
@@ -425,6 +429,7 @@ onBeforeRouteLeave(async () => {
         :space="space"
         :validation-failed="hasAuthorValidationFailed"
         :is-valid-author="isValidAuthor"
+        :is-valid-space="isValidSpaceSettings"
         :validation-name="validationName"
         :contains-short-url="formContainsShortUrl"
         data-testid="create-proposal-connect-wallet-warning"
@@ -494,7 +499,8 @@ onBeforeRouteLeave(async () => {
             hasAuthorValidationFailed ||
             validationLoading ||
             isGnosisAndNotSpaceNetwork ||
-            space.hibernated
+            space.hibernated ||
+            !isValidSpaceSettings
           "
           primary
           :data-testid="

From 9cc25960dd7a039cd2b98907eb17bb947370edcc Mon Sep 17 00:00:00 2001
From: Chaitanya <yourchaitu@gmail.com>
Date: Tue, 28 Nov 2023 11:45:19 +0530
Subject: [PATCH 2/3] fix: Don't run votes query for default value (#4405)

---
 src/composables/useProposals.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/composables/useProposals.ts b/src/composables/useProposals.ts
index 4d20225e..f398bdf7 100644
--- a/src/composables/useProposals.ts
+++ b/src/composables/useProposals.ts
@@ -54,7 +54,7 @@ export function useProposals() {
 
   const { apolloQuery } = useApolloQuery();
   async function getUserVotedProposalIds(voter: string, proposals: string[]) {
-    if (!voter || !proposals) return;
+    if (!voter || !proposals?.length) return;
     const votes = await apolloQuery(
       {
         query: USER_VOTED_PROPOSAL_IDS_QUERY,

From f83c1c1583858d731c4e0b3aaf86df22108dc3f1 Mon Sep 17 00:00:00 2001
From: Chaitanya <yourchaitu@gmail.com>
Date: Tue, 28 Nov 2023 15:15:07 +0530
Subject: [PATCH 3/3] fix: quorum placeholder in read-only mode is confusing
 (#4412)

---
 src/components/SettingsVotingBlock.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/SettingsVotingBlock.vue b/src/components/SettingsVotingBlock.vue
index bc00b288..7aea1134 100644
--- a/src/components/SettingsVotingBlock.vue
+++ b/src/components/SettingsVotingBlock.vue
@@ -32,7 +32,7 @@ const { form } = useFormSpaceSettings(props.context);
           :label="$t('settings.quorum.label')"
           :hint="$t('settings.quorum.information')"
           :disabled="isViewOnly"
-          placeholder="1000"
+          placeholder="0"
           type="number"
           @update:model-value="value => (form.voting.quorum = Number(value))"
         />