Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetcher-default as a plugin #181

Open
balashashanka opened this issue May 5, 2020 · 4 comments
Open

Add fetcher-default as a plugin #181

balashashanka opened this issue May 5, 2020 · 4 comments
Milestone

Comments

@balashashanka
Copy link

Currently the fetcher default is in package edu.usc.irds.sparkler.util, this issue is to move this as a plugin.

@balashashanka
Copy link
Author

Started working on this will be creating a pull request soon.

@thammegowda
Copy link
Member

Thanks.
we kept the default implementation in the sparkler-app itself for a few simplifications.

FYI, there are three fetcher plugins already if you want to test plugin loading (without having to develop a new one)https://github.com/USCDataScience/sparkler/tree/master/sparkler-plugins

That being said, all improvements are welcomed. just trying to make it easy for you.

@balashashanka
Copy link
Author

Hi I saw this is as one of the the TODO's in the code so thought it would be a good start.
But i could work on other things if this plugin is not in priority.

@thammegowda
Copy link
Member

You were facing an issue regarding deployment of plugins on sparkler cluster, right?
I suggest resolving that as a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants