-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Front Matter for style.css #2
Comments
Interesting! I didn't know you could do that with Jekyll front matter in a stylesheet. Good point about pulling out variables to make the switch-out easier. A thought: if we are going to start down this path, though, we may want to take advantage of GitHub's upgrade to Jekyll 2.2.0 and its automatic Sass parsing. Could separate out variables as is standard in Sass and set the template that way. |
Great point about Saas. Now that I looked up what it is, it seems like an ideal fit. Looks like we could change the imports to take advantage of the preprocessing as well. Does it still make sense to have the style.scss in the "static" folder? Once it's processed it is static I suppose? ---
---
$nav-color: #09c;
@import 'normalize';
@import 'fonts';
...
nav li:hover {
color: #75787b;
+ border-left: 4px solid $nav-color;
background-color: transparent;
border-bottom: 1px solid #d0d0ce;
padding-left: 0;
nav li:active {
color: #75787b;
+ border-left: 4px solid $nav-color;
background-color: transparent;
border-bottom: 1px solid #d0d0ce;
padding-left: 0; |
I could make this a pull request, but I think there are a few other issues to address first, like #5. |
I'd like to see
To have the partials in a sub-folder, we will need to add I don't have time today to do a pull request, but hopefully next week! This is great stuff -- cleaning up our template, it'll be so beautiful 😢 |
Where do you see these fitting?
|
…efault template to refer to local resources (though I think we need a variable here for ghpages branches). Created placeholder includes.
…efault template to refer to local resources (though I think we need a variable here for ghpages branches). Created placeholder includes.
To make it easier for different organizations to customize this project, maybe the styles.css could be processed to allow replacement of colors and maybe some image.
This diff is a good example of changing out a key color for tailoring to a new organization.
https://github.com/GSA/sam_api/commit/5cb8faeedbc80b0c50bcc6fd4ea54081509b2c22#diff-a16a51aaea7dc21d3202074fc7228024
Something along these lines:
The text was updated successfully, but these errors were encountered: