Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-existing SongDir entries in config.ini are created #916

Open
barbeque-squared opened this issue Oct 24, 2024 · 2 comments
Open

non-existing SongDir entries in config.ini are created #916

barbeque-squared opened this issue Oct 24, 2024 · 2 comments

Comments

@barbeque-squared
Copy link
Member

How to reproduce:

in config.ini:

[Directories]
SongDir1=/path/that/does/not/exist/but/this/user/has/the/rights/to/create

then start the game

Expected result: if the full path does not exist, USDX just ignores it (maybe log about it)

Actual result: the path appears to be created like mkdir --parents

Imo, song scanning should not be creating any directory ever. And it currently doesn't log anything for non-existing, non-writable locations anyway, so just ignoring it would already be better than what it's doing now. It probably should still get logged (to prevent issues from people that it's not finding their songs) but it's otherwise unrelated to what this issue is all about.

Obviously this only works for writeable locations, which is really annoying if you just add some garbage to one of your SongDir entries to effectively toggle some part of your collection being available or not. Or in the real world: songs contains songs, songs_extra is a SongDir which has the everything else. I can really do without it creating useless songs_extraDISABLED, songs_extraAAAAAAA, songs_extra_disabled etc folders.

@basisbit
Copy link
Member

This is a linux-only issue. Can not reproduce the problem on Windows.

@DeinAlptraum
Copy link
Contributor

That's kind of surprising, this looks like it should create the missing directory in every case.

The only problem here is that the function AddSpecialPath is used to create the paths for other stuff as well, so we'd have to disentangle this a bit/decide that new directories should not be created for the other cases as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants