Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end validation of payment form should be improved #50

Open
Jean-M22 opened this issue Mar 18, 2024 · 2 comments
Open

Front-end validation of payment form should be improved #50

Jean-M22 opened this issue Mar 18, 2024 · 2 comments
Labels
bug Something isn't working front-end Issue relating to UI/UX

Comments

@Jean-M22
Copy link
Collaborator

Jean-M22 commented Mar 18, 2024

Phone number field doesn't allow for international prefixes

image

CNP field length is not checked, but it is required. Also, what do we do for student who are not romanian citizens?

image

@Jean-M22 Jean-M22 added bug Something isn't working front-end Issue relating to UI/UX labels Mar 18, 2024
@Jean-M22 Jean-M22 changed the title Phone number field doesn't allow for international prefixes Front-end validation of payment form should be improved Mar 18, 2024
@GabrielMajeri
Copy link
Member

Phone number field doesn't allow for international prefixes

This restriction should be lifted, since we might have foreign candidates paying their admission tax using this app.

CNP field length is not checked. Also, what do we do for student who are not romanian citizens?

We actually really need this information only for Romanian citizens paying with the didactic career premium card (to issue them invoices). For others, it's stored just for informational/logging purposes.

@Jean-M22
Copy link
Collaborator Author

I found something else

If the captcha validation expires this is how it looks:
image
If the user reverifies, it changes to this:
image

The second text should appear in the first case and no text should appear in the second case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Issue relating to UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants