Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with --enable-benchmarks, nc_perf, unit tests #2627

Closed
WardF opened this issue Feb 16, 2023 · 1 comment · Fixed by #2628
Closed

Issues with --enable-benchmarks, nc_perf, unit tests #2627

WardF opened this issue Feb 16, 2023 · 1 comment · Fixed by #2628
Assignees
@WardF
Labels
area/build/autoconf area/build/cmake type/performance performance related issues

Comments

@WardF
Copy link
Member

WardF commented Feb 16, 2023

While investigating #2626, I discovered a few issues with the performance tests/benchmarks.

  • Benchmark and performance tests can't be enabled under cmake.
  • make check fails to compile when --enable-benchmarks is specified w/out using parallel compilation.
@WardF WardF added this to the 4.9.2 milestone Feb 16, 2023
@WardF WardF self-assigned this Feb 16, 2023
@WardF
Copy link
Member Author

WardF commented Feb 16, 2023 •
edited
Loading

Todo

  • Enable unit tests by default.
  • Wire in benchmarks option to CMakeLists.txt
  • Make performance tests which require mpi conditional on parallel compilation.
  • Ensure performance checks pass.

@WardF WardF changed the title Issues with --enable-benchmarks, nc_perf Issues with --enable-benchmarks, nc_perf, unit tests Feb 16, 2023
@WardF WardF mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WardF WardF

Labels
area/build/autoconf area/build/cmake type/performance performance related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit Testing, Performance Testing infrastructure options. WardF/netcdf-c
1 participant
@WardF