Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCT link hardwired into all ncISO records is broken #36

Open
rsignell-usgs opened this issue Nov 6, 2017 · 4 comments
Open

WCT link hardwired into all ncISO records is broken #36

rsignell-usgs opened this issue Nov 6, 2017 · 4 comments

Comments

@lesserwhirls
Copy link
Collaborator

Interesting, I don't think I've ever noticed the wct viewer link in there before. @noaaroland - do you know of an updated url for wct?

The thing about setting godiva as the viewer is that wms isn't enabled by default on 4.x servers, and most servers I've visited do not turn it on.

@rsignell-usgs
Copy link
Contributor Author

rsignell-usgs commented Nov 7, 2017

@lesserwhirls, I should have been more clear: I'm not proposing to hardwire godiva in there.
I think hardwiring anything in the nciso code is a bad idea.
We should only add godiva as a viewer if WMS is enabled on the dataset (and perhaps after checking if the getcaps actually returns a reponse!)

Methinks nciso has the information it needs to do that already!

@lesserwhirls
Copy link
Collaborator

Ah, yes, that makes sense. I think that could be added pretty easily. However, I'm a bit reluctant to do that asap, as I would like to see the two versions of the iso code merged so that we have one codebase, if possible (that is, this). @noaaroland @kevin-obrien - where does the standalone app stand at this point? Is there still interest in getting things under one codebase?

@kevin-obrien
Copy link
Collaborator

Yes, @lesserwhirls absolutely under once codebase would be ideal. At the NetCDF meeting in Sept, you mentioned that you thought there were a few libraries and/or methods missing. We should follow up on this discussion soon and figure out how to identify what is missing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants