Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (again) our deprecated hashing methods #234

Open
chriswk opened this issue Dec 7, 2023 · 0 comments
Open

Remove (again) our deprecated hashing methods #234

chriswk opened this issue Dec 7, 2023 · 0 comments
Assignees

Comments

@chriswk
Copy link
Member

chriswk commented Dec 7, 2023

Describe the feature request

To avoid users complaining about not seeing full/even distribution we should remove the methods that were added in 9.2.0 for simplifying the upgrade path from 8.x to 9.x. Ideally in 10.x but at the latest at 11.x

Background

In #232 an active user complained that the upgrade from 8.3.1 to 9.x broke the way they worked, so in 9.2.0 we added methods allowing to use the old seed for the hashing of the variants.

Solution suggestions

As the title says, we should remove the deprecated methods as soon as possible, to avoid having more users falling down the rabbit hole of having a 10% allocation getting the feature and then not seeing a 50/50 split between two variants of 50% / 50% weight.

@chriswk chriswk self-assigned this Dec 7, 2023
@thomasheartman thomasheartman moved this from New to In Progress in Issues and PRs Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant