-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlite resource #6
base: main
Are you sure you want to change the base?
Conversation
Tutorial on godot engine resourcesThe normal flow is you only have one remap pointer like Using godot-whisper design. This is also a problem in iree.gd and this sqlite pull request. Problem 1In your design, you have no pointers, and the data resource is the string of the path. So you must go to the export dialogue and manually whitelist the whisper model. Problem 2I can only ZSTD compress the resource data, a string like "res://model.whisper". I want Godot Engine to compress the model with ZSTD compression as a Problem 3I want to transfer the model over the network. Syncing the data property with a resource is enough to do this. |
It MAY be called data or some other property name. It MUST have a property that stores a transformed database data structure. https://datatracker.ietf.org/doc/html/rfc2119#section-1 Example workflow 1:
Example workflow 2:
|
I don't have enough design sense to review adding an ORM.
For this pull request, please keep creating a resource database and the I would postpone the object relation mapping to a subsequent pull request. https://martinfowler.com/bliki/OrmHate.html suggests either spending a lot of time writing a better objection relation mapper or avoiding the problem. Edited: According to the title, a SQLite resource is what is requested, not an Object Relation Mapper. |
22af952
to
354fa66
Compare
What parts did Piet Bronders & Jeroen De Geeter do? |
Can you separate the object relation mapping system into a different pr? I have to focus on other essential tasks, and I want to merge the Resource saver, resource loader, and sqlite node. Also, I'm curious about who those third-party people are. |
Well, no parts he did, but the High Level api is similar to his one (and I took inspiration from his repo) |
I could try later |
Makes sqlite resource visible in editor