Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code deduplication in heuristics #1181

Closed
jcoupey opened this issue Nov 6, 2024 · 1 comment · Fixed by #1177
Closed

Code deduplication in heuristics #1181

jcoupey opened this issue Nov 6, 2024 · 1 comment · Fixed by #1177
Labels
internals refactor
Milestone
v1.15.0

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 6, 2024

As sonarcloud reports in #1177, there is quite some code duplication across the basic and dynamic heuristics implementation. We could refactor to simplify the code and reduce duplication with a few helper functions, the main (quite) similar part being the route seeding strategy.
@jcoupey jcoupey added this to the v1.15.0 milestone Nov 6, 2024
@jcoupey jcoupey mentioned this issue Nov 6, 2024
Merged
7 tasks
@jcoupey
Copy link
Collaborator Author

jcoupey commented Nov 6, 2024

The main route-filling loop is also a great contender for deduplication, both loops are totally identical except for regrets that have a slightly different structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals refactor
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging a pull request may close this issue.

Apply heuristics for partial solutions VROOM-Project/vroom
1 participant
@jcoupey