Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translations for disenchant message #135

Open
f90 opened this issue Sep 4, 2020 · 0 comments
Open

Add translations for disenchant message #135

f90 opened this issue Sep 4, 2020 · 0 comments
Assignees
@Vapok @Taidtuskecyh
Labels
enhancement New feature or request

Comments

@f90
Copy link

f90 commented Sep 4, 2020

The announcement when selecting the disenchant option for an item is currently hardcoded in English, and cannot be translated. We should switch to using the translation object core.L and add the current English version to all the localisation files so people can translate it into their language.

https://github.com/Vapok/CommunityDKP/blob/master/Modules/LootPriceTab.lua#L85
@f90 f90 added the enhancement New feature or request label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vapok Vapok

@Taidtuskecyh Taidtuskecyh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Vapok @f90 @Taidtuskecyh