Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Table can't handle MonolithDKP-style decay #147

Open
MrTreng opened this issue Oct 22, 2020 · 1 comment
Open

Validate Table can't handle MonolithDKP-style decay #147

MrTreng opened this issue Oct 22, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MrTreng
Copy link

MrTreng commented Oct 22, 2020

I have a DKP table that I have been using since MonolithDKP. When I switched to CommunityDKP, I used the import functionality to keep our DKP data, which contained DKP decay entries that simply store the desired decay percentage, e.g. "-20%", instead of absolute DKP values.

When I try to use the Validate Table function from CommunityDKP version 3.2.3, I get a LUA error in Validate.lua:106, indicating that tonumber(dkp[j]) resolved to nil.

When I look at the surrounding code, you seem to assume that all values in the dkp fields can be converted to numbers. I also noticed that the decay entires generated by CommunityDKP store the absolute DKP deductions for each player in an array-string.

@MrTreng MrTreng added the bug Something isn't working label Oct 22, 2020
@lantisnt
Copy link

lantisnt commented Oct 23, 2020

@Vapok I hit the same issue when dealing with the bot.
There are basically 2 cases:

  1. Monolith stores % as last entry, and that can be completely disregarded as in the user list there is additional comma , with empty entry
  2. Very old version of Monolith stored a single "-X%" as value entry. This is something you can deal with as you don't know the DKP value at that point. In the Discord bot I disregard those entries at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants