Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different settings per raid group #83

Open
sarahbau opened this issue Jul 3, 2020 · 1 comment
Open

Allow different settings per raid group #83

sarahbau opened this issue Jul 3, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request Version 4

Comments

@sarahbau
Copy link

sarahbau commented Jul 3, 2020

Is your feature request related to a problem? Please describe.
One of the raid groups in my guild decided that starting next raid, they are going to have a 20dkp minimum bid rather than 10 that both raids currently have. The other group will stick with 10 min for now, but is considering going to a flat rate percentage based cost. Right now CommunityDKP does not support different settings, so each raid leader will have to double check the settings before each raid (possibly broadcasting settings - I'm not sure what happens when the RL has flat rate mode and the raiders have bid mode).

Describe the solution you'd like
The guild-wide default should remain, but maybe have a check box in the settings for overriding the settings for the currently selected raid group. If that box is checked, updating the settings would update an independent set of settings. They could be stored in

CommDKP_DB = {
    ["<server>"] = {
        ["<guild>"] = {
            ["0"] = {
                ["override_default_mode"] = true,
                ["modes"] = {
                ...

(basically the same format as now, just within the team)

Describe alternatives you've considered
The alternative suggested by the other officers is just each leader having their own settings, and never broadcasting them. As I said above, I'm not sure if the RL and raiders can even have wildly different modes and still have everything work.

Another alternative is for each RL to go through every option before every raid and broadcast settings

The final alternative is to just make sure all raid teams always have the same settings

Additional context
None

@sarahbau sarahbau added the enhancement New feature or request label Jul 3, 2020
@Vapok
Copy link
Owner

Vapok commented Jul 6, 2020

Hi Sara, thanks for the detailed feature request and even the inclusion of how the data structures might work. Overall, I like the idea of allowing the teams to have different settings per raid team. The data structure is only 1/3 of the solution. The other 2/3's is that the UI of the addon is created on the client load in. This also means that the bid windows, the buttons, how the addon reacts, object names, etc, are all initialized at the moment the client UI is loaded in.

So, what that would mean, in the current form of the addon, is that, when you swap teams that use a different addon, EVERYONE in the raid would have to reload their UI in order for it to work. I'm going to leave this open as I do want to get to a point where this is used, but the technicalities of how the UI loads is a major hurdle to overcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Version 4
Projects
None yet
Development

No branches or pull requests

3 participants