Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-Property Support with streaming intraday tables #254

Closed
FlorianASchroeder opened this issue Jul 28, 2023 · 2 comments · Fixed by #257
Closed

Multi-Property Support with streaming intraday tables #254

FlorianASchroeder opened this issue Jul 28, 2023 · 2 comments · Fixed by #257

Comments

@FlorianASchroeder
Copy link
Contributor

FlorianASchroeder commented Jul 28, 2023 •
edited
Loading

Due to a recent change in #250 it is not possible anymore to use multiple properties together with streaming support.
This breaks the feature introduced by #187.

Can this be enabled again anytime soon?
@adamribaudo-velir
Copy link
Collaborator

adamribaudo-velir commented Jul 30, 2023 •
edited
Loading

I started working on this but there's a problem...

dbt needs to know if the intraday tables exist at compile time in order to conditionally include the source_intraday CTE in base_ga4__events.

But the intraday tables are not copied into the destination dataset until after the combine_property_data() macro has run at runtime.

We could add a user variable back in saying union_intraday_events=true|false, but I would love for the solution to just work without additional configuration. Any ideas?

@adamribaudo-velir adamribaudo-velir mentioned this issue Jul 30, 2023
Merged
2 tasks
@adamribaudo-velir
Copy link
Collaborator

Figured this out (I think). Fix is in #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix streaming support for multi property configurations Velir/dbt-ga4
2 participants
@FlorianASchroeder @adamribaudo-velir