Fix window controls (popouts and visual refresh) and focus window method by patching window controls wrapper module #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1077
Fixes #964
This patches Discord's module that wraps around native IPC methods for windowing and some other utilities to call
VesktopNative.winmethods instead ofDiscordNative.windowmethodsThis includes
focuswhich was used by RPC deep linking. No difference will occur from this change, but if any of those other handlers are later supported through arRPC, it won't be necessary to patch the focus method in those handlers.This does not fix the missing always on top support in call popouts (doesnt work on wayland, I gave up on fixing that for that reason)