Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate File/Object Functionality to Prototype #67

Open
agilgur5 opened this issue Dec 25, 2015 · 1 comment
Open

Migrate File/Object Functionality to Prototype #67

agilgur5 opened this issue Dec 25, 2015 · 1 comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: RegionEditor Related to the Region Editor scope: Simulator Related to the Simulator scope: SpecEditor Related to the Spec Editor

Comments

@agilgur5
Copy link
Contributor

agilgur5 commented Dec 25, 2015

E.g. execute shouldn't be called from the executor and passed in an automaton, it should be a function on the automaton's prototype. getCentroid() should be part of the regions's prototype (and possibly stored in the returned region object somewhere too). etc.

@agilgur5 agilgur5 added scope: SpecEditor Related to the Spec Editor scope: Simulator Related to the Simulator scope: RegionEditor Related to the Region Editor labels Dec 25, 2015
@agilgur5
Copy link
Contributor Author

agilgur5 commented Apr 8, 2018

I actually left them all as functions because they're pure and can just be called from a module (which now they are split into). For ease of use, it might make sense to also allow the ability to bind all the functions to an object, i.e. a function that modifies an object with all the methods bound to it. Not sure if worthwhile or makes sense, but this is an interesting problem as it's nice to have the simplicity via OO-style but then you lose out on some benefits of the functional paradigm ¯\(ツ)

@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: RegionEditor Related to the Region Editor scope: Simulator Related to the Simulator scope: SpecEditor Related to the Spec Editor
Projects
None yet
Development

No branches or pull requests

1 participant