fix: remove leading slash on Windows #1230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
reviewed
Jan 20, 2025
lib/src/commands/packages/commands/check/commands/licenses.dart
Outdated
Show resolved
Hide resolved
I think the tests kind of are already there because the only way to test this would be to validate the whole Just enabling the tests to run for windows would be enough. Considering only the Considering the whole test suite: |
|
The problem is we can't enable all of them at once or else the pipeline will break. It has to be incremental, by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Removes leading
/for file paths on Windows during license checking, by leveraging toFilePath instead of path.Fixes #1227.
Uri
Before:
Before:
Logs
Before:
After:
Type of Change