From 647652cda9104c4e9777bdab6f8496a6a58406c3 Mon Sep 17 00:00:00 2001
From: Travis Spomer <16262858+TravisSpomer@users.noreply.github.com>
Date: Sun, 5 May 2024 14:56:25 -0700
Subject: [PATCH] Gems aren't upgrades #notallgems

---
 Pawn.lua   | 2 +-
 Readme.htm | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Pawn.lua b/Pawn.lua
index 2cfb1d6..99abc62 100644
--- a/Pawn.lua
+++ b/Pawn.lua
@@ -3487,7 +3487,7 @@ function PawnIsItemAnUpgrade(Item, DoNotRescan)
 	local CompareUsingItemLevelOnly = (Item.Rarity == 6)
 	local InvType = Item.InvType
 	if not InvType or InvType == "" or InvType == "INVTYPE_BAG" or InvType == "INVTYPE_QUIVER" or InvType == "INVTYPE_TABARD" or InvType == "INVTYPE_BODY" or ((not VgerCore.RangedSlotExists) and (InvType == "INVTYPE_THROWN" or InvType == "INVTYPE_AMMO" or InvType == "INVTYPE_RELIC")) then return nil end
-	local SkipScoreBasedUpgrades = InvType == "INVTYPE_TRINKET"
+	local SkipScoreBasedUpgrades = InvType == "INVTYPE_TRINKET" or PawnGetSlotsForItemType(InvType) == nil
 	local UnenchantedItemLink, NeedsEnhancements = PawnUnenchantItemLink(Item.Link, true)
 	VgerCore.Assert(UnenchantedItemLink ~= nil, "PawnIsItemAnUpgrade failed to get an item link for item " .. tostring(Item.ID))
 
diff --git a/Readme.htm b/Readme.htm
index a454d80..033dda2 100644
--- a/Readme.htm
+++ b/Readme.htm
@@ -312,6 +312,7 @@ <h3>Version 2.9.1</h3>
 	<li>Cataclysm Classic: Pawn will now recommend the proper gems based on the new colors and stats of existing gems.</li>
 	<li>Cataclysm Classic: Fixed a bug that caused a few stat weights to get reset to 0 when editing in the Weights tab and then reloading.</li>
 	<li>Cataclysm Classic: Added support for all of the new Cataclysm gems, which Pawn will start recommending as you get Cataclysm gear.</li>
+	<li>Fixed a bug that caused gems to always appear as upgrades.</li>
 </ul>
 <h3>Version 2.9.0</h3>
 <ul>