From 3930eb35c00ac0394c5c616b033618ddddbba43b Mon Sep 17 00:00:00 2001
From: James Longo <v-jameslongo@microsoft.com>
Date: Fri, 18 Oct 2024 13:20:21 -0400
Subject: [PATCH] updated actions/download-artifact@v1/2/3 -> v4

---
 .github/workflows/build_docs.yml          |  4 ++--
 .github/workflows/build_nuget.yml         |  2 +-
 .github/workflows/build_python_wheels.yml |  2 +-
 .github/workflows/dotnet_nugets.yml       | 16 ++++++++--------
 .github/workflows/lint.yml                |  2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/build_docs.yml b/.github/workflows/build_docs.yml
index 5c7015208..62339920f 100644
--- a/.github/workflows/build_docs.yml
+++ b/.github/workflows/build_docs.yml
@@ -71,11 +71,11 @@ jobs:
         if: github.event_name == 'release'
         run: echo "FOLDER_NAME=$(echo ${GITHUB_REF:10})" >> $GITHUB_ENV
       - name: Download c++ Docs
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v4
         with:
           name: cxx_docs
       - name: Download Python Docs
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v4
         with:
           name: python_docs
       - uses: actions/checkout@v1
diff --git a/.github/workflows/build_nuget.yml b/.github/workflows/build_nuget.yml
index 04325a63c..bf137f05b 100644
--- a/.github/workflows/build_nuget.yml
+++ b/.github/workflows/build_nuget.yml
@@ -132,7 +132,7 @@ jobs:
           echo "version=$version" >> $GITHUB_OUTPUT
       
       # Download and install nuget
-      - uses: actions/download-artifact@v1
+      - uses: actions/download-artifact@v4
         with:
           name: RLClientLibNativeStatic-${{ matrix.toolset }}-${{ matrix.build_type }}-x64.${{ steps.get_version.outputs.version }}.nupkg
           path: downloaded_nugets
diff --git a/.github/workflows/build_python_wheels.yml b/.github/workflows/build_python_wheels.yml
index 379bdd2d6..e1b75bd16 100644
--- a/.github/workflows/build_python_wheels.yml
+++ b/.github/workflows/build_python_wheels.yml
@@ -53,7 +53,7 @@ jobs:
         with:
           submodules: recursive
       - name: Download Wheel
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v4
         with:
           name: wheel_${{ matrix.config.version }}
       - name: Test wheel
diff --git a/.github/workflows/dotnet_nugets.yml b/.github/workflows/dotnet_nugets.yml
index 9e52b97e2..194766c40 100644
--- a/.github/workflows/dotnet_nugets.yml
+++ b/.github/workflows/dotnet_nugets.yml
@@ -144,15 +144,15 @@ jobs:
           echo "Generated version number: $version"
           echo "RL_NUGET_VERSION=$GENERATED_VERSION" >> $GITHUB_ENV
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: artifacts
+          name: artifacts-ubuntu-latest
           path: artifacts
       - uses: NuGet/setup-nuget@v1.1.1
       - run: nuget pack nuget/dotnet/rl.net.nuspec -Properties RL_NUGET_PACKAGE_VERSION=$RL_NUGET_VERSION -BasePath artifacts -OutputDirectory nuget_output
       - uses: actions/upload-artifact@v4
         with:
-          name: dist-${{ matrix.config.os_name }}
+          name: dist-ubuntu-latest
           path: nuget_output/
 
   test-nuget:
@@ -161,9 +161,9 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - { os: "windows-latest", runtime_id: "win-x64" }
-          - { os: "ubuntu-latest", runtime_id: "linux-x64" }
-          - { os: "macos-13", runtime_id: "osx-x64" }
+          - { os: "windows-latest", os_name: "windows-latest", runtime_id: "win-x64" }
+          - { os: "ubuntu-latest", os_name: "ubuntu-latest", runtime_id: "linux-x64" }
+          - { os: "macos-13", os_name: "macos-latest", runtime_id: "osx-x64" }
     runs-on: ${{matrix.config.os}}
     name: test-nuget (${{ matrix.config.os_name }}, ${{ matrix.config.runtime_id }})
     steps:
@@ -178,9 +178,9 @@ jobs:
           GENERATED_VERSION=$(./.scripts/version_number.py)
           echo "Generated version number: $version"
           echo "RL_NUGET_VERSION=$GENERATED_VERSION" >> $GITHUB_ENV
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: dist
+          name: dist-${{ matrix.config.os_name }}
           path: dist
       - uses: actions/setup-dotnet@v3
       - name: Install package
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index e2a8b7dca..6e5404c3f 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -50,7 +50,7 @@ jobs:
         with:
           submodules: recursive
       - name: Download Wheel
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v4
         with:
           name: wheel_${{ matrix.config.version }}
       - name: Install dependencies