From a742ac1851a6b064be099edfb199bdc6e6b751fc Mon Sep 17 00:00:00 2001 From: "xtlsheep@gmail.com" Date: Wed, 18 Dec 2024 19:44:53 +0000 Subject: [PATCH] Update spec based on comments and suggestions --- spec.bs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spec.bs b/spec.bs index 1839619ef..72631953e 100644 --- a/spec.bs +++ b/spec.bs @@ -8418,9 +8418,9 @@ an {{unsigned short}}-or-null |experimentGroupId|, an [=origin=] |topLevelOrigin 1. [=list/Append=] |group|'s [=interest group/trusted bidding signals keys=] into |compressionGroupMap|[|compressionGroupId|][|partitionId|]["bidding_keys"]. 1. [=map/For each=] |id| → |group| in |compressionGroupMap|: - 1. Let |compressionGroup| be an empty [=bidding compression group=]. - 1. Set |compressionGroup|'s [=bidding compression group/compression group id=] to |id|. - 1. Set |compressionGroup|'s [=bidding compression group/partition=] to an empty [=list=]. + 1. Let |compressionGroup| be a [=bidding compression group=], whose + [=bidding compression group/compression group id=] is |id|, and + [=bidding compression group/partition=] is an empty [=list=]. 1. [=list/For each=] |partition| in |group|'s [=map/values=]: 1. [=list/Append=] |partition| to |compressionGroup|'s [=bidding compression group/partition=]. 1. [=list/Append=] |compressionGroup| to |compressionGroups|. @@ -8807,7 +8807,6 @@ To batch and fetch trusted scoring signals given a [=trusted scoring 1. Otherwise: 1. Select a non-[=list/is empty|empty=] [=set/subset=] of |batcher|'s [=trusted scoring signals batcher/request map=][|key|], called |entriesToBatch|. - 1. Set |entriesToBatch| to |batcher|'s [=trusted scoring signals batcher/request map=][|key|]. 1. [=map/Remove=] |key| from |batcher|'s [=trusted scoring signals batcher/request map=]. 1. Let « |requestBody|, |renderUrlIdMap|, |context| » be the result of [=building batched trusted key value scoring signals request body=] for |entriesToBatch|. @@ -8833,6 +8832,7 @@ To batch and fetch trusted scoring signals given a [=trusted scoring 1. If |scoringDataVersionMap| is not null: 1. Set |result|'s [=trusted scoring signals reply/data version=] to |scoringDataVersionMap| [|entry|'s [=URL serializer|serialized=] [=trusted scoring signals request/render URL=]]. + 1. Set |entry|'s [=trusted scoring signals request/reply=] to |result|. 1. Otherwise, [=list/for each=] |entry| in |entriesToBatch|: 1. Set |entry|'s [=trusted scoring signals request/reply=] to failure.