-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuyerAndSellerReportingId overwrites BuyerReportingId #1380
Comments
Chrome permits returning an empty string for selectableBASRI (pretty sure you still have to declare this in each of the IG's ads 🙄) so you can get all your ids. |
The problem is not at selectableBASRI but at selectedBASRI. Even if the buyer provides buyerReportingId, buyerAndSellerReporingId, selectableBASRI (non-empty) for a particular ad, it does not mean that generateBid will always return selectedBASRI. When the selectedBASRI is not returned from generateBid, buyer still wants to know the buyerReportingId, which currently is infeasible because of this overwriting behavior. |
I'm with you there. |
Yes this will do the work. I hope if Chrome folks can confirm this behavior. |
Additionaly, if selectedBASRI is not from selectableBASRI, what is the overwriting behavior here? |
As I recall from the FLEDGE call, the empty string selectedBASRI returned with the bid must be present in the corresponding ad in IG.ads[].selectableBASRI[]. Per Explainer,
My bid was rejected with Worklet error: https://testhost.net/static/bidding-logic.js generateBid() bids sequence entry: Invalid selected buyer and seller reporting id |
This means that when an ad has selectableBASRI, the buyer should always put an empty string just in case generateBid can set selectBASRI as this empty string. In this way the overwriting behavior can be prevented. This sounds odd to me. I hope Chrome folks can clarify if this is the intention. |
As per the privacy sandbox guidance, buyerAndSellerReportingId will overwrite buyerReportingId when generateBid does not return selectedBuyerAndSellerReportingId.
This is unexpected because buyerReportingId contains information that buyer does not want to share with seller. If an ad contains buyerReportingId, buyerAndSellerReportingId and selectableBuyerAndSellerReportingIds but generateBid does not return selectedBuyerAndSellerReportingId, buyer still wants to know buyerReportingId.
The text was updated successfully, but these errors were encountered: