Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve algorithms that take a version type #254

Closed
miketaylr opened this issue Sep 13, 2021 · 0 comments
Closed

Improve algorithms that take a version type #254

miketaylr opened this issue Sep 13, 2021 · 0 comments

Comments

@miketaylr
Copy link
Collaborator

Right now (as soon as #250 lands) there's this hand-wavey notion of "version type" that's both a type and a value. It's not great!

Instead, let's pass either a string "full version" or "significant version" or some internal enum like enum versionType {"full-version", "significant-version"} and then fork behavior inside the algorithm based on that.
@miketaylr miketaylr mentioned this issue Sep 13, 2021
Merged
5 tasks
miketaylr added a commit to miketaylr/ua-client-hints that referenced this issue Sep 20, 2021
@miketaylr
Issue WICG#254 - Improve algorithms that take a "version type"
c348f64
miketaylr added a commit to miketaylr/ua-client-hints that referenced this issue Sep 21, 2021
@miketaylr
Issue WICG#254 - Address review feedback
5cf8fee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miketaylr